Jun 28 2007

Art of Code Reviewing

Category: .live and learnAmit Bahree @ 11:27 am

This is a true story and happened on one of my projects (which shall remain nameless). Below is the feedback from one of the client as they were doing our code reviews.

Line 66: there seem to be a few too many words starting with "f" in the salutations comment. [This is really picky – the commenting standard in this file has otherwise been really good so far.]

And incase you were wondering what was the code in question, here it is:

/// <param name="salutations">The selection of Titles for which to choose from for a Contact</param>

So, what is the problem you ask? Who said there was a problem. Geeked

Share
Similar posts to check out:
  • March 4, 2011 -- Is technology making us less human? (0)
    Guardian story Social networking under fresh attack as tide of cyber-scepticism sweeps US where a number of academics have done studies which conclude that Twitter and Facebook don't connect people, but on the contrary they isolate them from reality got me thinking about this and wonder if Technology is making us less human! MIT professor Sherry Turkle's new book Alone Together (which seems interesting and is something I have not had the bandwidth to check out), is leading an attack on the in...
  • January 12, 2011 -- What Baby App? (0)
    Any suggestions for any a good iPhone App for tracking Baby feeds, sleeping, pumping, etc. that the wife can use? Below is a list of what I was able to find online; some of these on reading the reviews seem better than others but no one specifically stood out. Anyone with real world experience? Baby Brain Baby Tracker PeeDoodle BabyBix Baby Connect Total baby As of now, we are leaning towards Total Baby....
  • October 23, 2010 -- How to best use TFS? (0)
    So you have a team (somewhat like mine right now) which is inexperienced with TFS and not very sure about this whole branching, merging, shelveset thinggy and extremely nervous when using it. So, what will you do? Well you might try and train them, show them how to use it, write documents showing how to use it, have processes in place, try and use some tools to help, etc. But, what do they do? Well this seems to be along the lines .... :roll: ...

Tags:

Leave a Reply

*

Get Adobe Flash playerPlugin by wpburn.com wordpress themes